srdo commented on issue #2980: STORM-3361: Include dependency license file in distributions, clean u… URL: https://github.com/apache/storm/pull/2980#issuecomment-480514979 Just to summarize what the aim of this change is (and hopefully help reviewers): LICENSE and NOTICE contain licenses and notices for our source, following the guide at http://www.apache.org/dev/licensing-howto.html. These are the L&N included in our storm-dist/source distribution. LICENSE-binary is LICENSE, plus a list of dependencies of the storm-dist/binary project (i.e. everything we put in the binary distribution), plus the list of shaded artifacts from shaded-deps. This follows the http://www.apache.org/dev/licensing-howto.html#binary guideline. I've put the license texts in the license directory, and mention the link in LICENSE-binary. The addition to LICENSE-binary is generated by following the steps in DEVELOPER.md to get the license list for storm-dist/binary, editing the output a bit by hand, and adding the shaded-deps dependencies by hand. The licenses in the `licenses` directory are downloaded by following the steps in DEVELOPER.md to download licenses, then renaming the fetched files to be a bit more readable. NOTICE-binary is NOTICE, plus concatenated NOTICEs from storm-dist/binary dependencies. The appended text is generated using the steps in DEVELOPER.md (the `collect_license_files` script). The script is a lightly modified version of the script Flink uses https://github.com/apache/flink/blob/master/tools/releasing/collect_license_files.sh. This follows the http://www.apache.org/dev/licensing-howto.html#mod-notice guideline. LICENSE-binary and NOTICE-binary are renamed and included as LICENSE/NOTICE in the binary distribution. DEPENDENCY-LICENSES is included in either distribution, and simply lists all Storm's dependencies and their licenses. The licenses are included in the `licenses` directory. The file is there to cover https://apache.org/legal/resolved.html#appropriately-labelled-condition for category B dependencies. I'm not positive we need this file, but it would be to make users aware of category B dependencies we don't distribute directly, but are needed to use e.g. connector modules.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
