srdo commented on a change in pull request #3000: STORM-3381: Exclude
spotbugs-annotations from Zookeeper, regen DEPEND…
URL: https://github.com/apache/storm/pull/3000#discussion_r276363736
##########
File path: DEPENDENCY-LICENSES
##########
@@ -584,6 +582,7 @@ List of third-party dependencies grouped by their license
type.
* Woodstox (org.codehaus.woodstox:woodstox-core-asl:4.4.1 -
http://woodstox.codehaus.org)
* Xerces2 Java Parser (xerces:xercesImpl:2.9.1 -
http://xerces.apache.org/xerces2-j)
* XML Commons External Components XML APIs (xml-apis:xml-apis:1.3.04 -
http://xml.apache.org/commons/components/external/)
+ * zookeeper (org.apache.zookeeper:zookeeper:3.4.14 - no url defined)
Review comment:
The file is autogenerated. It will just get overwritten. Best fix is to get
Zookeeper to add an URL to their pom. As far as I can tell they're in the
middle of a migration to Maven, and the new pom has an URL in the license
section
https://github.com/apache/zookeeper/blob/ff47fc3dfda3487ca3a5aca2ea16831b2aebc7e2/pom.xml#L54
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services