srdo commented on a change in pull request #3000: STORM-3381: Exclude
spotbugs-annotations from Zookeeper, regen DEPEND…
URL: https://github.com/apache/storm/pull/3000#discussion_r276561971
##########
File path: DEPENDENCY-LICENSES
##########
@@ -584,6 +582,7 @@ List of third-party dependencies grouped by their license
type.
* Woodstox (org.codehaus.woodstox:woodstox-core-asl:4.4.1 -
http://woodstox.codehaus.org)
* Xerces2 Java Parser (xerces:xercesImpl:2.9.1 -
http://xerces.apache.org/xerces2-j)
* XML Commons External Components XML APIs (xml-apis:xml-apis:1.3.04 -
http://xml.apache.org/commons/components/external/)
+ * zookeeper (org.apache.zookeeper:zookeeper:3.4.14 - no url defined)
Review comment:
I checked and it doesn't look like there's a way to override the urls
currently. The missing file format (the stuff in THIRD-PARTY.properties) only
allows you to set a license name, not a dependency URL.
The element I pointed to before was wrong, it's actually this one that needs
to be set
https://github.com/apache/zookeeper/blob/ff47fc3dfda3487ca3a5aca2ea16831b2aebc7e2/pom.xml#L46
Making these overridable is going to need a fix in the license plugin, I'll
raise an issue, but I can't see how it can be fixed without replacing the
missing file format.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
