Yes, we already have a check that the Maven version is above 3.0.0 ( https://github.com/apache/storm/blob/master/pom.xml#L1439), IMO we can just bump it to something like 3.5.0. I'll raise an issue for it.
Den ons. 1. maj 2019 kl. 20.59 skrev Alexandre Vermeerbergen < [email protected]>: > Hello Stig, > > Good catch: I upgraded Maven to version 3.6.1 and I rebuilt everything > from source tar.gz without any trouble. > > So I delay my vote and I'm no longer blocked since I have > storm-kafka-client-2.0.0.jar allowing me to rebuilt my topologies. > > Just a question: since my experience showed that build Storm 2.0.0 > break with Maven 3.3.9, wouldn't it be possible to improve Storm's > pom.xml to include a Maven version check (see > https://maven.apache.org/enforcer/enforcer-rules/versionRanges.html) ? > > This would improve Storm users' experience a little bit, and sounds > very simple to do (not a blocker for 2.0.0 of course). > > How about that? > > Kind regards, > Alexandre Vermeerbergen > > Le mer. 1 mai 2019 à 19:42, Stig Rohde Døssing > <[email protected]> a écrit : > > > > I haven't seen the error you're getting before, but it looks like it's a > > Maven issue, not a Storm issue. Could you try updating to the latest > Maven > > version? > > > > Den ons. 1. maj 2019 kl. 19.30 skrev Alexandre Vermeerbergen < > > [email protected]>: > > > > > Hello, > > > > > > I don't know if this is worth a -1 because maybe I did something > > > wrong, but I got a failure when trying to build binaries from the > > > sources, see attached log (zipped) with 4 errors, captured from the > > > output of: > > > > > > mvn clean install -DskipTests 2>&1 build_Storm_2.0.0_rc7.log > > > > > > more details on my machine: > > > > > > $ cat /etc/redhat-release > > > CentOS release 6.7 (Final) > > > > > > $ mvn -version > > > Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; > > > 2015-11-10T17:41:47+01:00) > > > Maven home: /home/data/ave/maven/src/apache-maven-3.3.9 > > > Java version: 1.8.0_66, vendor: Oracle Corporation > > > Java home: /usr/java/jdk1.8.0_66_x86_64/jdk1.8.0_66/jre > > > Default locale: en_US, platform encoding: UTF-8 > > > OS name: "linux", version: "2.6.32-573.el6.x86_64", arch: "amd64", > > > family: "unix" > > > > > > I got couple of JAR files built, but I'm missing the > > > storm-kafka-client one, so am blocked because I need this "external" > > > lib to test my topologies rebuilt with Storm 2.0.0 RC7 > > > > > > Did I missed something that break my Storm 2.0.0 RC7 build? > > > > > > Kind regards, > > > Alexandre Vermeerbergen > > > > > > > > > Le mar. 30 avr. 2019 à 00:49, P. Taylor Goetz <[email protected]> a > écrit > > > : > > > > > > > > This is a call to vote on releasing Apache Storm 2.0.0 (rc7) > > > > > > > > Full list of changes in this release: > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.0.0-rc7/RELEASE_NOTES.html > > > > > > > > The tag/commit to be voted upon is v2.0.0: > > > > > > > > > > > > https://git-wip-us.apache.org/repos/asf?p=storm.git;a=tree;h=007863edd95e838b3df414928c6fa3f28244ab49;hb=2ba95bbd1c911d4fc6363b1c4b9c4c6d86ac9aae > > > > > > > > The source archive being voted upon can be found here: > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.0.0-rc7/apache-storm-2.0.0-src.tar.gz > > > > > > > > Other release files, signatures and digests can be found here: > > > > > > > > https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.0.0-rc7/ > > > > > > > > The release artifacts are signed with the following key: > > > > > > > > > > > > https://git-wip-us.apache.org/repos/asf?p=storm.git;a=blob_plain;f=KEYS;hb=22b832708295fa2c15c4f3c70ac0d2bc6fded4bd > > > > > > > > The Nexus staging repository for this release is: > > > > > > > > > https://repository.apache.org/content/repositories/orgapachestorm-1079 > > > > > > > > Please vote on releasing this package as Apache Storm 2.0.0. > > > > > > > > When voting, please list the actions taken to verify the release. > > > > > > > > This vote will be open for at least 72 hours. > > > > > > > > [ ] +1 Release this package as Apache Storm 2.0.0 > > > > [ ] 0 No opinion > > > > [ ] -1 Do not release this package because... > > > > > > > > Thanks to everyone who contributed to this release. > > > > > > > > -Taylor > > > >
