srdo commented on a change in pull request #3096: STORM-3480 Implement One
Worker Per Executor RAS Option
URL: https://github.com/apache/storm/pull/3096#discussion_r310344090
##########
File path:
storm-server/src/main/java/org/apache/storm/scheduler/SchedulerAssignmentImpl.java
##########
@@ -45,7 +43,7 @@
*/
private final Map<ExecutorDetails, WorkerSlot> executorToSlot = new
HashMap<>();
private final Map<WorkerSlot, WorkerResources> resources = new HashMap<>();
- private final Map<String, Double> nodeIdToTotalSharedOffHeap = new
HashMap<>();
+ private final Map<String, Double> nodeIdToTotalSharedOffHeapNode = new
HashMap<>();
Review comment:
Nit: I'm not sure why adding "Node" to all these variables makes it clearer
what they contain. E.g. for this one, I think node id -> shared offheap is more
readable than node id -> shared offheap node.
If other people prefer the new names, it's fine though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
