srdo commented on a change in pull request #3096: STORM-3480 Implement One
Worker Per Executor RAS Option
URL: https://github.com/apache/storm/pull/3096#discussion_r310344228
##########
File path:
storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/BaseResourceAwareStrategy.java
##########
@@ -148,9 +153,12 @@ protected WorkerSlot findWorkerForExec(ExecutorDetails
exec, TopologyDetails td,
for (String id : sortedNodes) {
RAS_Node node = nodes.getNodeById(id);
if (node.couldEverFit(exec, td)) {
+ Collection<WorkerSlot> topologyUsedSlots =
oneWorkerPerExecutor ? node.getUsedSlots(td.getId()) : null;
Review comment:
Set this to `Collections.emptySet()` instead of null, then you can get rid
of the null check below.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
