Ethanlm commented on a change in pull request #3096: STORM-3480 Implement One
Worker Per Executor RAS Option
URL: https://github.com/apache/storm/pull/3096#discussion_r312060357
##########
File path:
storm-server/src/test/java/org/apache/storm/scheduler/resource/strategies/scheduling/TestDefaultResourceAwareStrategy.java
##########
@@ -93,31 +104,119 @@ public TestDNSToSwitchMapping(Map<String,
SupervisorDetails> ... racks) {
}
};
- @Rule
- public NormalizedResourcesRule nrRule = new NormalizedResourcesRule();
-
- @After
+ @AfterEach
public void cleanup() {
if (scheduler != null) {
scheduler.cleanup();
scheduler = null;
}
}
+ /*
+ * test assigned memory with shared memory types and oneWorkerPerExecutor
+ */
+ @ParameterizedTest
+ @EnumSource(sharedMemoryType.class)
+ public void
testMultipleSharedMemoryWithOneWorkerPerExecutor(sharedMemoryType memoryType) {
+ int spoutParallelism = 4;
+ double cpuPercent = 10;
+ double memoryOnHeap = 10;
+ double memoryOffHeap = 10;
+ double sharedOnHeapWithinWorker = 450;
+ double sharedOffHeapNode = 600;
+ double sharedOffHeapWithinWorker = 400;
+
+ TopologyBuilder builder = new TopologyBuilder();
+ switch (memoryType) {
+ case SHARED_OFF_HEAP_NODE:
+ builder.setSpout("spout", new TestSpout(), spoutParallelism)
+ .addSharedMemory(new
SharedOffHeapWithinNode(sharedOffHeapNode, "spout shared node"));
+ break;
+ case SHARED_OFF_HEAP_WORKER:
+ builder.setSpout("spout", new TestSpout(), spoutParallelism)
+ .addSharedMemory(new
SharedOffHeapWithinWorker(sharedOffHeapWithinWorker, "spout shared off heap
worker"));
+ break;
+ case SHARED_ON_HEAP_WORKER:
+ builder.setSpout("spout", new TestSpout(), spoutParallelism)
+ .addSharedMemory(new
SharedOnHeap(sharedOnHeapWithinWorker, "spout shared worker"));
Review comment:
The name should include "on heap" to make it more clear
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
