Ethanlm commented on a change in pull request #3096: STORM-3480 Implement One
Worker Per Executor RAS Option
URL: https://github.com/apache/storm/pull/3096#discussion_r311772414
##########
File path:
storm-server/src/test/java/org/apache/storm/scheduler/resource/strategies/scheduling/TestDefaultResourceAwareStrategy.java
##########
@@ -67,11 +72,17 @@
import org.apache.storm.metric.StormMetricsRegistry;
import org.apache.storm.scheduler.resource.normalization.ResourceMetrics;
+@ExtendWith({NormalizedResourcesExtension.class})
public class TestDefaultResourceAwareStrategy {
private static final Logger LOG =
LoggerFactory.getLogger(TestDefaultResourceAwareStrategy.class);
private static final int CURRENT_TIME = 1450418597;
private static IScheduler scheduler = null;
+ private enum sharedMemoryType {
Review comment:
Class or enum name should be Upper CamelCase. i.e **S**haredMemoryType
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
