Ethanlm commented on a change in pull request #3108: [STORM-3492] Add config to 
prevent good supervisor with bad workers f…
URL: https://github.com/apache/storm/pull/3108#discussion_r315895526
 
 

 ##########
 File path: storm-server/src/main/java/org/apache/storm/DaemonConfig.java
 ##########
 @@ -137,6 +137,13 @@
     @IsImplementationOfClass(implementsClass = IBlacklistStrategy.class)
     public static final String BLACKLIST_SCHEDULER_STRATEGY = 
"blacklist.scheduler.strategy";
 
+    /**
+     * Whether the blacklistscheduler will put a supervisor to blacklist when 
there is a bad slot/worker
 
 Review comment:
   We could clarify this a little bit here. It's not really put into the 
blacklist directly because of a bad slot. 
   
   Also in the javadoc, we can refer to blacklist scheduler using {@link 
org.apache.storm.scheduler.blacklist.BlacklistScheduler}. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to