Ethanlm commented on a change in pull request #3108: [STORM-3492] Add config to
prevent good supervisor with bad workers f…
URL: https://github.com/apache/storm/pull/3108#discussion_r316252850
##########
File path: storm-server/src/main/java/org/apache/storm/DaemonConfig.java
##########
@@ -137,6 +137,17 @@
@IsImplementationOfClass(implementsClass = IBlacklistStrategy.class)
public static final String BLACKLIST_SCHEDULER_STRATEGY =
"blacklist.scheduler.strategy";
+ /**
+ * Whether {@link org.apache.storm.scheduler.blacklist.BlacklistScheduler}
will assume the supervisor is bad
+ * based on bad slots or not.
+ * A bad slot indicates the situation where the nimbus doesn't receive
heartbeat from the worker in time,
+ * it's hard to differentiate if it's because of the supervisor node or
the worker itself.
+ * If this is set to true, the scheduler will consider a supervisor is bad
when seeing bad slots in it.
+ * Otherwise, the scheduler will assume a supervisor is bad only when it
does not receive supervisor heartbeat in time.
+ */
+ @IsBoolean
+ public static final String BLACKLIST_SUPERVISOR_BASED_ON_BAD_SLOT =
"blacklist.scheduler.assume.supervisor.bad.based.on.bad.slot;
Review comment:
Let's make the variable name and the value consistent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
