govind-menon commented on a change in pull request #3146: STORM-3521: Adds ugly
workaround to deal with topology main arguments…
URL: https://github.com/apache/storm/pull/3146#discussion_r336654182
##########
File path: storm-client/test/py/test_storm_cli.py
##########
@@ -67,6 +67,25 @@ def test_jar_command(self):
])
)
+ self.mock_execvp.reset_mock()
+
+ self.base_test([
+ 'storm', 'jar', '/path/to/jar.jar', 'some.Topology.Class',
+ '-name', 'run-topology', 'randomArgument', '-randomFlag',
'randomFlagValue', '-rotateSize', '0.0001',
+ '-hdfsConf',
'dfs.namenode.kerberos.principal.pattern=hdfs/*.EV..COM'
+ ], self.mock_execvp, mock.call(
+ self.java_cmd, [
+ self.java_cmd, '-client','-Ddaemon.name=', '-Dstorm.options=',
+ '-Dstorm.home=' + self.storm_dir + '', '-Dstorm.log.dir=' +
self.storm_dir + "/logs",
+ '-Djava.library.path=', '-Dstorm.conf.file=', '-cp',
+ '' + self.storm_dir + '/*:' + self.storm_dir + '/lib:' +
self.storm_dir
+ + '/extlib:/path/to/jar.jar:' + self.storm_dir + '/conf:' +
self.storm_dir + '/bin:',
+ '-Dstorm.jar=/path/to/jar.jar', '-Dstorm.dependency.jars=',
'-Dstorm.dependency.artifacts={}',
+ 'some.Topology.Class', '-name', 'run-topology',
'randomArgument', '-randomFlag', 'randomFlagValue',
+ '-rotateSize', '0.0001',
'dfs.namenode.kerberos.principal.pattern=hdfs/*.EV..COM', '-hdfsConf'
Review comment:
Good catch - the filtered flags are re-added at the end. The argument is of
the form -hdfsConf=someValue so the order shouldn't matter
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
