govind-menon commented on a change in pull request #3146: STORM-3521: Adds ugly
workaround to deal with topology main arguments…
URL: https://github.com/apache/storm/pull/3146#discussion_r336653944
##########
File path: bin/storm.py
##########
@@ -1464,18 +1464,32 @@ def print_server_classpath(args):
def monitor(args):
exec_storm_class(
"org.apache.storm.command.Monitor",
storm_config_opts=args.storm_config_opts,
- args=remove_common_options(sys.argv[2:]),
+ main_class_args=remove_common_options(sys.argv[2:]),
jvmtype="-client",
extrajars=[USER_CONF_DIR, STORM_BIN_DIR])
+def is_not_conflicting_jar_argument(raw_arg):
+ # TODO refactor underlying Topology main classes to avoid this ugly hack
+ conflicting_flags = ["-hdfsConf"]
Review comment:
That's the ugly part - the conflict is that the way the HdfsTopology
specifies the argument is non-unix compliant. And there's no consistent way to
identify all such possible flags so I'm only filtering this one for now and add
more later
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
