Ethanlm opened a new pull request #3149: [STORM-3527] getWorkerUser() should 
never return empty username
URL: https://github.com/apache/storm/pull/3149
 
 
   https://issues.apache.org/jira/browse/STORM-3527
   
   In some rare cases, `workers-users/<workerid>` can be empty:
   
   
https://github.com/apache/storm/blob/master/storm-server/src/main/java/org/apache/storm/daemon/supervisor/Container.java#L561-L565
   
   >  protected void saveWorkerUser(String user) throws IOException {
           type.assertFull();
           LOG.info("SET worker-user {} {}", workerId, user);
           ops.dump(new File(ConfigUtils.workerUserFile(conf, workerId)), user);
       }
   
   Above code could be interrupted because supervisor got killed/terminated. So 
the file could be created but left as empty. 
   
   Supervisor will then never be able to clean up directories for this worker 
because it can't get the worker user information correctly
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to