Ethanlm commented on issue #3141: STORM-3518: Add support to (un)favored nodes with range format URL: https://github.com/apache/storm/pull/3141#issuecomment-544979842 Thanks for working on this. The idea of unfavored/favored nodes is that users can specify it in their topologies so when nimbus schedules the topology, it will try to scheduled tasks to favored nodes first, and try to avoid scheduling on unfavored nodes. There are multiple places where unfavored/favored nodes are being used. 1. https://github.com/apache/storm/blob/master/storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/GenericResourceAwareStrategy.java#L102-L103 2. https://github.com/apache/storm/blob/master/storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/ConstraintSolverStrategy.java#L257-L258 3. https://github.com/apache/storm/blob/master/storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/DefaultResourceAwareStrategy.java#L63-L64 We can have common methods in Config.java to get favored/unfavored nodes. And replace above three.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
