> But for this release, I think it’s fine for now. What do you think? Yes, I agree it is not a blocker for the release.
On Thu, Oct 31, 2019 at 10:24:15AM -0500, Ethan Li wrote: > > Derek, > > I would think this not a blocker. We don’t really test JDK9. We only have > JDK8 and JDK11 test on travis. We can have a separate JIRA if we want to deal > with JDK9. > But for this release, I think it’s fine for now. What do you think? > > Thanks > Ethan > > > On Oct 31, 2019, at 9:04 AM, Rui Li <[email protected]> wrote: > > > > +1 > > Built from source using maven 3.6.1. > > Ran unit tests. > > Built local cluster and submitted and killed a WordCountTopology using > > storm jar and storm kill. > > Launched localhost UI and it worked fine > > > > > > Best, > > Rui > > > >> On Oct 31, 2019, at 1:44 AM, Stig Rohde Døssing <[email protected]> > >> wrote: > >> > >> Derek, > >> > >> Are you using Maven 3.6.2? There's a bug causing it to fail to look in the > >> right repositories for dependencies in some cases > >> https://github.com/apache/maven/pull/294. If you're using 3.6.2, please try > >> building with 3.6.1 until that issue is fixed. The kafka-avro-serializer > >> jar is in Confluent's Maven repo. > >> > >> Regarding the illegal reflective access, is the test failing or just > >> warning about the illegal access? The Kryo guys seem to think it's just a > >> little annoying, but shouldn't break anything > >> https://github.com/EsotericSoftware/kryo/issues/543#issuecomment-395894516. > >> Our CI builds with Java 11 (excluding some Hadoop and Cassandra stuff), so > >> am a little surprised if one of the tests fail on Java 9+. > >> > >> Den tor. 31. okt. 2019 kl. 02.43 skrev Derek Dagit <[email protected]>: > >> > >>> Differencing the source from version control versus the source in the > >>> tar.gz: > >>> > >>> * We are distributing several dependency-reduced-pom.xml files that are > >>> not part of the source. > >>> * There is what appears to be a test directory accidentally included at > >>> apache-storm-2.1.0/storm-core/null/ > >>> > >>> These are not blockers for a release. > >>> > >>> When building the source with `mvn clean install -DskipTests=true`: > >>> > >>> * Build fails for flux-examples due to a missing dependency for > >>> storm-hdfs: io.confluent:kafka-avro-serializer:jar:1.0 > >>> > >>> Clearing the dependency-reduced-pom.xml files mentioned above does not > >>> resolve the problem. > >>> > >>> This may be a blocker if it prevents the build generally. Has anyone > >>> else had trouble downloading this dependency? If not, from where is > >>> the dependency downloaded? > >>> > >>> > >>> When testing with `mvn clean install` > >>> > >>> * The following warning fails test-clojure in storm-core: > >>> WARNING: Illegal reflective access by > >>> com.esotericsoftware.kryo.util.UnsafeUtil > >>> > >>> This may have to do with changes beginning with Java 9: > >>> http://openjdk.java.net/jeps/261#Relaxed-strong-encapsulation > >>> > >>> When using Java 8 I do not see this failure. > >>> > >>> This probably should not be a blocker, but we may have to have a > >>> work-around. > >>> > >>> -- > >>> Derek > >>> > >>> > >>> On Wed, Oct 30, 2019 at 04:23:11PM -0400, Kishorkumar Patil wrote: > >>>> > >>>> +1. > >>>> > >>>> Built from code. Executed based wordcount and drpc topologies. I executed > >>>> and compared Based ThroughtputVsLatency and performance and resource uses > >>>> is same as 2.0.0 release. > >>>> > >>>> -Kishor > >>>> > >>>> On Wed, Oct 30, 2019 at 3:44 PM Aaron Gresch <[email protected]> wrote: > >>>> > >>>>> +1 > >>>>> > >>>>> Built and ran tests from source. > >>>>> Ran local WordCountTopology, ran a rebalance and kill and looked at > >>> logs > >>>>> for ERRORs. > >>>>> Validated storm blobstore list and jar command with -c option worked. > >>>>> > >>>>> > >>>>> On Fri, Oct 25, 2019 at 3:09 PM Ethan Li <[email protected]> wrote: > >>>>> > >>>>>> This is a call to vote on releasing Apache Storm 2.1.0 (rc5) > >>>>>> > >>>>>> Full list of changes in this release: > >>>>>> > >>>>>> > >>>>>> > >>>>> > >>> https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.1.0-rc5/RELEASE_NOTES.html > >>>>>> > >>>>>> The tag/commit to be voted upon is v2.1.0: > >>>>>> > >>>>>> > >>>>>> > >>>>> > >>> https://gitbox.apache.org/repos/asf?p=storm.git;a=tree;h=9a4a245efeb6d74dc01b0feac77bda0e5709b3f6;hb=79fc9b3e6aeec623b42d165536a936d28f2b12f1 > >>>>>> > >>>>>> The source archive being voted upon can be found here: > >>>>>> > >>>>>> > >>>>>> > >>>>> > >>> https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.1.0-rc5/apache-storm-2.1.0-src.tar.gz > >>>>>> > >>>>>> Other release files, signatures and digests can be found here: > >>>>>> > >>>>>> https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.1.0-rc5 > >>>>>> > >>>>>> The release artifacts are signed with the following key: > >>>>>> > >>>>>> https://www.apache.org/dist/storm/KEYS > >>>>>> > >>>>>> The Nexus staging repository for this release is: > >>>>>> > >>>>>> > >>> https://repository.apache.org/content/repositories/orgapachestorm-1089/ > >>>>>> > >>>>>> Please vote on releasing this package as Apache Storm 2.1.0. > >>>>>> > >>>>>> When voting, please list the actions taken to verify the release. > >>>>>> > >>>>>> This vote will be open for at least 72 hours. > >>>>>> > >>>>>> [ ] +1 Release this package as Apache Storm 2.1.0 > >>>>>> [ ] 0 No opinion > >>>>>> [ ] -1 Do not release this package because... > >>>>>> > >>>>>> Thanks to everyone who contributed to this release. > >>>>>> > >>>>> > >>> > > >
