Ethanlm commented on a change in pull request #3170: STORM-3541 report v2
metrics api in metrics tick
URL: https://github.com/apache/storm/pull/3170#discussion_r362612671
##########
File path: storm-client/src/jvm/org/apache/storm/daemon/Task.java
##########
@@ -252,6 +252,8 @@ private TopologyContext mkTopologyContext(StormTopology
topology) throws IOExcep
executor.getIntervalToTaskToMetricToRegistry(),
executor.getOpenOrPrepareWasCalled(),
workerData.getMetricRegistry());
+ executor.setMetricRegistry(workerData.getMetricRegistry());
Review comment:
Should we put this line of code outside this function? They don't seem to be
related
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
