Ethanlm commented on a change in pull request #3170: STORM-3541 report v2 
metrics api in metrics tick
URL: https://github.com/apache/storm/pull/3170#discussion_r362622452
 
 

 ##########
 File path: storm-client/src/jvm/org/apache/storm/Config.java
 ##########
 @@ -263,6 +263,13 @@
      */
     @IsPositiveNumber(includeZero = true)
     public static final String TOPOLOGY_METRICS_CONSUMER_CPU_PCORE_PERCENT = 
"topology.metrics.consumer.cpu.pcore.percent";
+
+    /**
+     * This config allows a topology to report metrics data points from the V2 
metrics API through the metrics tick.
+     */
+    @IsBoolean
+    public static final String TOPOLOGY_ENABLE_V2_METRICS_TICK = 
"topology.enable.v2.metrics.tick";
 
 Review comment:
   If this is enabled and `storm.metrics.reporters` is configured, will the 
metrics be sent to multiple places?  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to