Ethanlm commented on a change in pull request #3208: [STORM-3579]  use the topo 
conf for thrift client in Worker code
URL: https://github.com/apache/storm/pull/3208#discussion_r378392648
 
 

 ##########
 File path: storm-client/src/jvm/org/apache/storm/daemon/worker/Worker.java
 ##########
 @@ -443,7 +451,7 @@ private void 
heartbeatToMasterIfLocalbeatFail(LSWorkerHeartbeat lsWorkerHeartbea
         } catch (Exception tr1) {
             //If any error/exception thrown, report directly to nimbus.
             LOG.warn("Exception when send heartbeat to local supervisor", 
tr1.getMessage());
-            try (NimbusClient nimbusClient = 
NimbusClient.getConfiguredClient(conf)) {
+            try (NimbusClient nimbusClient = 
NimbusClient.getConfiguredClient(topologyConf)) {
 
 Review comment:
   NimbusClient does not need a topoConf strictly. If it's used on supervisor, 
it will be a supervisor conf.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to