Ethanlm commented on a change in pull request #3208: [STORM-3579]  use the topo 
conf for thrift client in Worker code
URL: https://github.com/apache/storm/pull/3208#discussion_r378393664
 
 

 ##########
 File path: storm-client/src/jvm/org/apache/storm/daemon/worker/Worker.java
 ##########
 @@ -106,9 +105,9 @@
      * @param port           - port on which the worker runs
      * @param workerId       - worker id
      */
-
     public Worker(Map<String, Object> conf, IContext context, String 
topologyId, String assignmentId,
 
 Review comment:
   That would be great. Will do it (or some can do it) in the future if come 
across this code again. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to