Ethanlm commented on a change in pull request #3213: [STORM-3588] add
GenericResourceAwareSchedulingPriorityStrategy to accommodate generic resource
in grading topologies
URL: https://github.com/apache/storm/pull/3213#discussion_r384803453
##########
File path:
storm-server/src/test/java/org/apache/storm/scheduler/resource/TestUtilsForResourceAwareScheduler.java
##########
@@ -83,6 +88,10 @@ public void addSelfTo(Map<String, Map<String, Number>>
fullPool) {
}
}
+ public static TestUserResources userRes(String name, Map<String, Double>
resources) {
+ return new TestUserResources(name, resources);
Review comment:
This reminds me that we don't have a unit test to test the case where users
have the generic resource guarantee. But this can be a follow up work
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
