Ethanlm commented on a change in pull request #3213: [STORM-3588] add
GenericResourceAwareSchedulingPriorityStrategy to accommodate generic resource
in grading topologies
URL: https://github.com/apache/storm/pull/3213#discussion_r384793382
##########
File path:
storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/priority/DefaultSchedulingPriorityStrategy.java
##########
@@ -140,7 +140,7 @@ public int compare(SimulatedUser o1, SimulatedUser o2) {
* Comparator that sorts topologies by priority and then by submission
time.
* First sort by Topology Priority, if there is a tie for topology
priority, topology uptime is used to sort.
*/
- private static class TopologyByPriorityAndSubmissionTimeComparator
implements Comparator<TopologyDetails> {
+ protected static class TopologyByPriorityAndSubmissionTimeComparator
implements Comparator<TopologyDetails> {
Review comment:
This can be `private` since it's not used elsewhere ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
