bipinprasad commented on a change in pull request #3215: Storm3585 - New
compact Constraint config including maxCoLocationCnt
URL: https://github.com/apache/storm/pull/3215#discussion_r384870087
##########
File path:
storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/ConstraintSolverStrategy.java
##########
@@ -506,20 +581,21 @@ public SchedulingResult asSchedulingResult() {
return SchedulingResult.success("Fully Scheduled by
ConstraintSolverStrategy (" + statesSearched
+ " states traversed in " +
timeTakenMillis + "ms, backtracked " + backtracked + " times)");
}
+ state.logNodeCompAssignments();
return
SchedulingResult.failure(SchedulingStatus.FAIL_NOT_ENOUGH_RESOURCES,
"Cannot find scheduling that
satisfies all constraints (" + statesSearched
+ " states traversed in " +
timeTakenMillis + "ms, backtracked " + backtracked + " times)");
}
}
- protected static class SearcherState {
+ protected static final class SearcherState {
final long startTimeMillis;
private final long maxEndTimeMs;
// A map of the worker to the components in the worker to be able to
enforce constraints.
- private final Map<WorkerSlot, Set<String>> workerCompAssignment;
+ private final Map<WorkerSlot, Map<String, Integer>>
workerCompAssignment;
Review comment:
Changed names to end in Cnts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
