Ethanlm commented on a change in pull request #3215: Storm3585 - New compact
Constraint config including maxCoLocationCnt
URL: https://github.com/apache/storm/pull/3215#discussion_r387461422
##########
File path:
storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/ConstraintSolverStrategy.java
##########
@@ -262,28 +367,27 @@ public SchedulingResult schedule(Cluster cluster,
TopologyDetails td) {
//get mapping of components to executors
compToExecs = getCompToExecs(execToComp);
- //get topology constraints
- constraintMatrix = getConstraintMap(td, compToExecs.keySet());
Review comment:
This constraintMatrix includes system components, like `Acker` because it
gets components from execToComp
But `topo.getComponents().keySet()` in `new ConstraintConfig(td);` only
includes non-system components.
I have to say the storm code is confusing. But just want to point out the
different between these two that will cause some behavior changes because of
the code change here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
