Ethanlm commented on a change in pull request #3227: STORM-3602 fix switching
on low water mark for loadaware shuffle
URL: https://github.com/apache/storm/pull/3227#discussion_r392265285
##########
File path:
storm-client/src/jvm/org/apache/storm/grouping/LoadAwareShuffleGrouping.java
##########
@@ -305,7 +309,7 @@ public static Scope downgrade(Scope current) {
}
}
- public static Scope upgrade(Scope current) {
+ public static LocalityScope upgradeFromWorker(LocalityScope current) {
Review comment:
This name can be a little confusing. `upgradeFromWorker` implies the
current scope is `WORKER_LOCAL`.
I would prefer to keep `downgrade` and `upgrade`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
