Ethanlm commented on a change in pull request #3227: STORM-3602 fix switching
on low water mark for loadaware shuffle
URL: https://github.com/apache/storm/pull/3227#discussion_r392269309
##########
File path:
storm-client/src/jvm/org/apache/storm/grouping/LoadAwareShuffleGrouping.java
##########
@@ -47,13 +47,14 @@
private Random random;
private volatile int[] prepareChoices;
private AtomicInteger current;
- private Scope currentScope;
+ @VisibleForTesting
+ LocalityScope currentScope;
Review comment:
I would keep this as private and add a `getCurrentScope` function for test
only with `@VisibleForTesting` annotation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
