Ethanlm commented on a change in pull request #3237: STORM-3259: Adds NUMA
awareness to enable worker pinning
URL: https://github.com/apache/storm/pull/3237#discussion_r400992238
##########
File path:
storm-server/src/main/java/org/apache/storm/container/cgroup/CgroupManager.java
##########
@@ -203,6 +209,30 @@ public void reserveResourcesForWorker(String workerId,
Integer totalMem, Integer
}
}
+ if (numaId != null) {
Review comment:
Is this a different implementation than what we have internally?
Internally you used `numactl`. Here seems to be using cgroup directly. Is
this well tested?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
