Ethanlm commented on a change in pull request #3237: STORM-3259: Adds NUMA awareness to enable worker pinning URL: https://github.com/apache/storm/pull/3237#discussion_r400967075
########## File path: storm-server/src/main/java/org/apache/storm/daemon/supervisor/BasicContainer.java ########## @@ -665,8 +666,10 @@ protected String javaCmd(String cmd) { commandList.addAll(classPathParams); commandList.add(getWorkerMain(topoVersion)); commandList.add(topologyId); + if (numaId != null) { + supervisorId += Constants.NUMA_ID_SEPARATOR + numaId; Review comment: This changes `Container` attribute `supervisorId` when it `mkLaunchCommand`, which means the `supervisorId` is different depending on whether it calles `mkLaunchCommand` or not. I am afraid it might introduce confusions. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services