Ethanlm commented on a change in pull request #3237: STORM-3259: Adds NUMA awareness to enable worker pinning URL: https://github.com/apache/storm/pull/3237#discussion_r401240239
########## File path: storm-server/src/main/java/org/apache/storm/daemon/supervisor/BasicContainer.java ########## @@ -665,8 +666,10 @@ protected String javaCmd(String cmd) { commandList.addAll(classPathParams); commandList.add(getWorkerMain(topoVersion)); commandList.add(topologyId); + if (numaId != null) { + supervisorId += Constants.NUMA_ID_SEPARATOR + numaId; Review comment: I mostly worried about the order. If it's not called yet but accessed somewhere else, the result can be unexpected. We shouldn't implicitly change the meaning of the attribute `supervisorId`. If we want to attach "numa" to it, do it as earliest as possible so we know everywhere we see a `supervisorId` in Container, it has "numa" ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services