Ethanlm commented on a change in pull request #3237: STORM-3259: Adds NUMA
awareness to enable worker pinning
URL: https://github.com/apache/storm/pull/3237#discussion_r402615193
##########
File path:
storm-server/src/main/java/org/apache/storm/container/ResourceIsolationInterface.java
##########
@@ -37,7 +37,7 @@
* @param workerMemory the amount of memory for the worker or null if not
enforced
* @param workerCpu the amount of cpu for the worker or null if not
enforced
*/
- void reserveResourcesForWorker(String workerId, Integer workerMemory,
Integer workerCpu);
+ void reserveResourcesForWorker(String workerId, Integer workerMemory,
Integer workerCpu, String numaId);
Review comment:
missing `@param numaId`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
