RuiLi8080 commented on a change in pull request #3265:
URL: https://github.com/apache/storm/pull/3265#discussion_r422227238
##########
File path: storm-client/src/jvm/org/apache/storm/Config.java
##########
@@ -312,6 +312,13 @@
// the topology.
public static final String TOPOLOGY_SCHEDULER_STRATEGY =
"topology.scheduler.strategy";
+ /**
+ * When DefaultResourceAwareStrategy or GenericResourceAwareStrategy is
used,
+ * it will arrange unassigned executors based a particular order.
+ * If this config is set to true, the arrangement will be made by network
proximity needs.
+ */
+ public static final String TOPOLOGY_RAS_ORDER_EXECUTORS_BY_PROXIMITY_NEEDS
= "topology.ras.order.executors.by.proximity.needs";
Review comment:
1. I was using`Boolean orderByProximity = (Boolean)
td.getConf().getOrDefault(Config.TOPOLOGY_RAS_ORDER_EXECUTORS_BY_PROXIMITY_NEEDS,
false);` in BaseResourceAwareStrategy. That can also show this config in
topology UI. Now I also added that to defaults.yaml as well
2. Changed the name to include "schedule". I still keep "ras" since this is
only used in RAS scheduling.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
