Ethanlm commented on a change in pull request #3265:
URL: https://github.com/apache/storm/pull/3265#discussion_r426869553
##########
File path:
storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/BaseResourceAwareStrategy.java
##########
@@ -511,6 +514,18 @@ protected String nodeToRack(RasNode node) {
return sortedComponents;
}
+ protected List<ExecutorDetails> orderExecutors(
+ TopologyDetails td, Collection<ExecutorDetails> unassignedExecutors) {
+ Boolean orderByProximity = (Boolean) td.getConf()
Review comment:
We can use ObjectReader.getBoolean()
##########
File path: storm-client/src/jvm/org/apache/storm/Config.java
##########
@@ -312,6 +312,13 @@
// the topology.
public static final String TOPOLOGY_SCHEDULER_STRATEGY =
"topology.scheduler.strategy";
+ /**
+ * When DefaultResourceAwareStrategy or GenericResourceAwareStrategy is
used,
+ * it will arrange unassigned executors based a particular order.
+ * If this config is set to true, the arrangement will be made by network
proximity needs.
+ */
+ public static final String
TOPOLOGY_RAS_SCHEDULE_EXECUTORS_BY_PROXIMITY_NEEDS =
"topology.ras.schedule.executors.by.proximity.needs";
Review comment:
Maybe `topology.ras.order.executors.by.proximity.needs` has more
accurate meaning. This only changes how the unassigned executors are sorted.
How they are scheduled still depend on some other things too
##########
File path: storm-client/src/jvm/org/apache/storm/Config.java
##########
@@ -312,6 +312,13 @@
// the topology.
public static final String TOPOLOGY_SCHEDULER_STRATEGY =
"topology.scheduler.strategy";
+ /**
+ * When DefaultResourceAwareStrategy or GenericResourceAwareStrategy is
used,
+ * it will arrange unassigned executors based a particular order.
+ * If this config is set to true, the arrangement will be made by network
proximity needs.
Review comment:
maybe a little more explanation on what it really is will help users
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
