Ethanlm commented on a change in pull request #3307:
URL: https://github.com/apache/storm/pull/3307#discussion_r467289908
##########
File path:
storm-client/src/jvm/org/apache/storm/metrics2/StormMetricRegistry.java
##########
@@ -74,6 +74,13 @@
return gauge;
}
+ public Meter meter(String name, String topologyId, String componentId,
Integer taskId, Integer workerPort, String streamId) {
Review comment:
I thought you added streamId to the name, for example,
`__acked-count-comp1:stream1`
So I was thinking to make it consistent, move that logic to a more general
function like here. Instead of changing the name before calling this function.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
