Ethanlm commented on a change in pull request #3307:
URL: https://github.com/apache/storm/pull/3307#discussion_r467970008
##########
File path: storm-core/test/clj/org/apache/storm/nimbus_test.clj
##########
@@ -166,7 +183,7 @@
(HashMap.))]
(log-warn "curr-beat:" (prn-str curr-beat) ",stats:" (prn-str stats))
(log-warn "stats type:" (type stats))
- (.put stats (ClientStatsUtil/convertExecutor executor) (.renderStats
(BoltExecutorStats. 20 (*STORM-CONF* NUM-STAT-BUCKETS))))
+ (.put stats (ClientStatsUtil/convertExecutor executor) (new-stats))
Review comment:
Instead of implementing `bolt-stats` method here, we should probably use
`renderStats` method in `BoltExecutorMetrics`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
