bipinprasad commented on a change in pull request #3274:
URL: https://github.com/apache/storm/pull/3274#discussion_r511010233
##########
File path: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java
##########
@@ -810,9 +810,15 @@ private static int numUsedWorkers(SchedulerAssignment
assignment) {
return ret;
}
+ /**
+ * Check new assignments with existing assignments and determine
difference is any.
+ *
+ * @param existingAssignments non-null map of topology-id to existing
assignments.
+ * @param newAssignments non-null map of topology-id to new assignments.
+ * @return true if there is a change in assignments, false otherwise.
+ */
private boolean auditAssignmentChanges(Map<String, Assignment>
existingAssignments,
Map<String, Assignment>
newAssignments) {
- assert existingAssignments != null && newAssignments != null;
Review comment:
The two arguments are never null - and this is a private method - with
javadoc that says it should be non-null. See calling method.
If null is passed in some future code, then NullPointerException will be
thrown automatically. I can't think of alternative replacement code that will
behave differently, unless this method allows null, and null is treated as an
empty assignment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
