bipinprasad commented on a change in pull request #3274:
URL: https://github.com/apache/storm/pull/3274#discussion_r553469902
##########
File path:
storm-server/src/main/java/org/apache/storm/scheduler/TopologyDetails.java
##########
@@ -514,8 +514,13 @@ private void initConfigs() {
this.topologyPriority =
ObjectReader.getInt(topologyConf.get(Config.TOPOLOGY_PRIORITY),
null);
- assert this.topologyWorkerMaxHeapSize != null;
- assert this.topologyPriority != null;
+ // Fails in storm-core: org.apache.storm.scheduler-test / testname:
test-cluster
Review comment:
Upon further investigation:
- assert (original code) does not cause Clojure test failure - because
assert is not active at runtime
- replacement of assert - using AssertionError - (new code) will cause
Clojure test failure because it is active at runtime
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
