[GitHub] [storm] snikhil5 commented on a diff in pull request #3479: [STORM-3832] Moving unit tests from junit4 to junit5

[GitBox]

snikhil5 commented on code in PR #3479:
URL: https://github.com/apache/storm/pull/3479#discussion_r885713177


##########
storm-server/src/test/java/org/apache/storm/daemon/supervisor/SlotTest.java:
##########
@@ -177,39 +174,39 @@ public void testLaunchContainerFromEmpty() throws 
Exception {
             DynamicState nextState = Slot.stateMachineStep(dynamicState, 
staticState);
             verify(localizer).requestDownloadTopologyBlobs(newAssignment, 
port, cb);
             assertEquals(MachineState.WAITING_FOR_BLOB_LOCALIZATION, 
nextState.state);
-            assertSame("pendingDownload not set properly", blobFuture, 
nextState.pendingDownload);
+            assertSame(blobFuture, nextState.pendingDownload, "pendingDownload 
not set properly");
             assertEquals(newAssignment, nextState.pendingLocalization);
             assertEquals(0, Time.currentTimeMillis());
 
             nextState = Slot.stateMachineStep(nextState, staticState);
             verify(blobFuture).get(1000, TimeUnit.MILLISECONDS);
             verify(containerLauncher).launchContainer(port, newAssignment, 
state);
             assertEquals(MachineState.WAITING_FOR_WORKER_START, 
nextState.state);
-            assertSame("pendingDownload is not null", null, 
nextState.pendingDownload);
+            assertSame(null, nextState.pendingDownload, "pendingDownload is 
not null");

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org