[GitHub] [storm] snikhil5 commented on a diff in pull request #3479: [STORM-3832] Moving unit tests from junit4 to junit5

[GitBox]

snikhil5 commented on code in PR #3479:
URL: https://github.com/apache/storm/pull/3479#discussion_r885707398


##########
flux/flux-core/src/test/java/org/apache/storm/flux/multilang/MultilangEnvironmentTest.java:
##########
@@ -38,19 +38,19 @@ public class MultilangEnvironmentTest {
     public void testInvokePython() throws Exception {
         String[] command = new String[]{"python", "--version"};
         int exitVal = invokeCommand(command);
-        assertEquals("Exit value for python is 0.", 0, exitVal);
+        assertEquals(0, exitVal, "Exit value for python is 0.");
     }
 
     @Test
     public void testInvokeNode() throws Exception {
         String[] command = new String[]{"node", "--version"};
         int exitVal = invokeCommand(command);
-        assertEquals("Exit value for node is 0.", 0, exitVal);
+        assertEquals(0, exitVal, "Exit value for node is 0.");

Review Comment:
   done



##########
integration-test/src/test/java/org/apache/storm/st/tests/window/SlidingWindowTest.java:
##########
@@ -60,7 +57,7 @@ public void testWindowCount(int windowSize, int slideSize) 
throws Exception {
         if (windowSize <= 0 || slideSize <= 0) {
             try {
                 testable.newTopology();
-                Assert.fail("Expected IllegalArgumentException was not 
thrown.");
+                fail("Expected IllegalArgumentException was not thrown.");
             } catch (IllegalArgumentException ignore) {
                 return;
             }

Review Comment:
   done



##########
integration-test/src/test/java/org/apache/storm/st/tests/window/SlidingWindowTest.java:
##########
@@ -94,7 +90,7 @@ public void testTimeWindow(int windowSec, int slideSec) 
throws Exception {
         if (windowSec <= 0 || slideSec <= 0) {
             try {
                 testable.newTopology();
-                Assert.fail("Expected IllegalArgumentException was not 
thrown.");
+                fail("Expected IllegalArgumentException was not thrown.");
             } catch (IllegalArgumentException ignore) {
                 return;
             }

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org