[ 
https://issues.apache.org/jira/browse/STORM-295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13980156#comment-13980156
 ] 

ASF GitHub Bot commented on STORM-295:
--------------------------------------

Github user revans2 commented on the pull request:

    https://github.com/apache/incubator-storm/pull/85#issuecomment-41323561
  
    I really don't see why we need a shell script layer of indirection to sit 
on top of our python layer of indirection.  I would rather have the python do 
something simple like,
    ```
    JAVA_HOME=os.getenv('STORM_JAVA_HOME', os.getenv('JAVA_HOME', None))
    if JAVA_HOME is None:
      #look for java on the path and use that
    ```
    
    If we really feel that we need a separate config file to set JAVA_HOME and 
STORM_CONF_DIR, lets have it be written in python or be a simple config file 
and have storm work with it explicitly.


> Add storm configuration to define JAVA_HOME
> -------------------------------------------
>
>                 Key: STORM-295
>                 URL: https://issues.apache.org/jira/browse/STORM-295
>             Project: Apache Storm (Incubating)
>          Issue Type: Bug
>            Reporter: Suresh Srinivas
>
> Currently storm uses either /usr/bin/java (most likely) or java pointed to by 
> PATH.
> Storm requires a way to define JAVA_HOME in configuration. This will simplify 
> pointing to a version of java that a cluster admin or test frameworks intend 
> to use for storm, especially in an environments where multiple versions of 
> java is on the cluster nodes.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to