[
https://issues.apache.org/jira/browse/STORM-295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13980362#comment-13980362
]
ASF GitHub Bot commented on STORM-295:
--------------------------------------
Github user revans2 commented on the pull request:
https://github.com/apache/incubator-storm/pull/86#issuecomment-41337736
The code looks good to me. Please rename the pull request to have
"STORM-295" in it so the linkage happens. The only other issue I have is that
JAVA_HOME is not being propagated to the worker when it is launched. The
supervisor is still going off of the path.
> Add storm configuration to define JAVA_HOME
> -------------------------------------------
>
> Key: STORM-295
> URL: https://issues.apache.org/jira/browse/STORM-295
> Project: Apache Storm (Incubating)
> Issue Type: Bug
> Reporter: Suresh Srinivas
>
> Currently storm uses either /usr/bin/java (most likely) or java pointed to by
> PATH.
> Storm requires a way to define JAVA_HOME in configuration. This will simplify
> pointing to a version of java that a cluster admin or test frameworks intend
> to use for storm, especially in an environments where multiple versions of
> java is on the cluster nodes.
--
This message was sent by Atlassian JIRA
(v6.2#6252)