Github user revans2 commented on a diff in the pull request:
https://github.com/apache/incubator-storm/pull/94#discussion_r12329609
--- Diff:
external/storm-kafka/src/jvm/storm/kafka/DynamicBrokersReader.java ---
@@ -52,15 +51,15 @@ public DynamicBrokersReader(Map conf, String zkStr,
String zkPath, String topic)
Utils.getInt(conf.get(Config.STORM_ZOOKEEPER_RETRY_INTERVAL))));
_curator.start();
} catch (Exception ex) {
- LOG.error("can't connect to zookeeper");
+ LOG.error("Couldn't connect to zookeeper", ex);
}
}
/**
* Get all partitions with their current leaders
*/
- public GlobalPartitionInformation getBrokerInfo() {
- GlobalPartitionInformation globalPartitionInformation = new
GlobalPartitionInformation();
+ public GlobalPartitionInformation getBrokerInfo() throws
java.net.SocketTimeoutException {
--- End diff --
Do we want to import java.net.SocketTimeoutException as it is used more
then once? (very minor)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
