Github user revans2 commented on a diff in the pull request:
https://github.com/apache/incubator-storm/pull/94#discussion_r12329867
--- Diff: external/storm-kafka/src/jvm/storm/kafka/KafkaUtils.java ---
@@ -159,12 +171,17 @@ public static ByteBufferMessageSet
fetchMessages(KafkaConfig config, SimpleConsu
for (int errors = 0; errors < 2 && msgs == null; errors++) {
FetchRequestBuilder builder = new FetchRequestBuilder();
FetchRequest fetchRequest = builder.addFetch(topic,
partitionId, offset, config.fetchSizeBytes).
- clientId(config.clientId).build();
+
clientId(config.clientId).maxWait(config.fetchMaxWait).build();
FetchResponse fetchResponse;
try {
fetchResponse = consumer.fetch(fetchRequest);
} catch (Exception e) {
- if (e instanceof ConnectException) {
+ if (e instanceof ConnectException ||
--- End diff --
This is a java 7 specific construct. Currently we have JDK6 compatibility
listed in the pom. If we want to move to Java7, which I personally am OK with,
but I know others are not, we need to discuss this on the mailing list.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
