[
https://issues.apache.org/jira/browse/STORM-303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13990737#comment-13990737
]
ASF GitHub Bot commented on STORM-303:
--------------------------------------
Github user brndnmtthws commented on a diff in the pull request:
https://github.com/apache/incubator-storm/pull/94#discussion_r12329854
--- Diff:
external/storm-kafka/src/jvm/storm/kafka/DynamicBrokersReader.java ---
@@ -52,15 +51,15 @@ public DynamicBrokersReader(Map conf, String zkStr,
String zkPath, String topic)
Utils.getInt(conf.get(Config.STORM_ZOOKEEPER_RETRY_INTERVAL))));
_curator.start();
} catch (Exception ex) {
- LOG.error("can't connect to zookeeper");
+ LOG.error("Couldn't connect to zookeeper", ex);
}
}
/**
* Get all partitions with their current leaders
*/
- public GlobalPartitionInformation getBrokerInfo() {
- GlobalPartitionInformation globalPartitionInformation = new
GlobalPartitionInformation();
+ public GlobalPartitionInformation getBrokerInfo() throws
java.net.SocketTimeoutException {
--- End diff --
Probably a good idea.
> Forward port of storm-kafka work
> --------------------------------
>
> Key: STORM-303
> URL: https://issues.apache.org/jira/browse/STORM-303
> Project: Apache Storm (Incubating)
> Issue Type: Bug
> Affects Versions: 0.9.2-incubating
> Environment: linux
> Reporter: Brenden Matthews
>
> This is a placeholder issue for the patch at
> https://github.com/apache/incubator-storm/pull/94.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
