[
https://issues.apache.org/jira/browse/STORM-303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13999908#comment-13999908
]
ASF GitHub Bot commented on STORM-303:
--------------------------------------
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/incubator-storm/pull/94#discussion_r12745379
--- Diff: external/storm-kafka/src/jvm/storm/kafka/KafkaUtils.java ---
@@ -159,12 +171,17 @@ public static ByteBufferMessageSet
fetchMessages(KafkaConfig config, SimpleConsu
for (int errors = 0; errors < 2 && msgs == null; errors++) {
FetchRequestBuilder builder = new FetchRequestBuilder();
FetchRequest fetchRequest = builder.addFetch(topic,
partitionId, offset, config.fetchSizeBytes).
- clientId(config.clientId).build();
+
clientId(config.clientId).maxWait(config.fetchMaxWait).build();
FetchResponse fetchResponse;
try {
fetchResponse = consumer.fetch(fetchRequest);
} catch (Exception e) {
- if (e instanceof ConnectException) {
+ if (e instanceof ConnectException ||
--- End diff --
You are correct. I though I saw the java 7 ```catch ConnectException |
SocketTimeoutException | ...``` But I could be mistaken. It looks fine now
> Forward port of storm-kafka work
> --------------------------------
>
> Key: STORM-303
> URL: https://issues.apache.org/jira/browse/STORM-303
> Project: Apache Storm (Incubating)
> Issue Type: Bug
> Affects Versions: 0.9.2-incubating
> Environment: linux
> Reporter: Brenden Matthews
>
> This is a placeholder issue for the patch at
> https://github.com/apache/incubator-storm/pull/94.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
