Github user ptgoetz commented on the pull request:
https://github.com/apache/incubator-storm/pull/103#issuecomment-42479510
In general this looks good to me, but it needs to be reviewed by additional
committers familiar with the netty transport. Unit tests pass as did a basic
smoke test on a 3-node cluster.
As I mentioned in an earlier comment, the additional config parameters need
to be added to the `defaults.yaml` file, preferably with some
comments/documentation regarding usage and ramifications of certain settings
(e.g. sync vs. async). That way users won't have to dig around in source code
to determine the default values.
I also noticed that some of the changes you mentioned in the pdf doc don't
appear in this pull request (e.g. serialization.reserve.tuple.createTime)? I'm
just curious as to why you left some things out.
Thanks for the contribution!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
