Github user revans2 commented on a diff in the pull request:
https://github.com/apache/incubator-storm/pull/103#discussion_r12811853
--- Diff: storm-core/src/clj/backtype/storm/disruptor.clj ---
@@ -89,7 +90,7 @@
(consume-batch-when-available queue handler)
0 )
:kill-fn kill-fn
- :thread-name thread-name
+ :thread-name (.getName queue)
--- End diff --
The function this is a part of takes an optional :thread-name parameter.
We should either remove that parameter or honor it. I would vote to remove it,
because the only place I think it is called you modified as well (just below).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
