Github user revans2 commented on a diff in the pull request:
https://github.com/apache/incubator-storm/pull/103#discussion_r12813817
--- Diff:
storm-core/src/jvm/backtype/storm/messaging/netty/StormClientHandler.java ---
@@ -18,70 +18,24 @@
package backtype.storm.messaging.netty;
import java.net.ConnectException;
-import java.util.concurrent.atomic.AtomicBoolean;
-import org.jboss.netty.channel.Channel;
-import org.jboss.netty.channel.ChannelHandlerContext;
-import org.jboss.netty.channel.ChannelStateEvent;
-import org.jboss.netty.channel.ExceptionEvent;
-import org.jboss.netty.channel.MessageEvent;
-import org.jboss.netty.channel.SimpleChannelUpstreamHandler;
+import org.jboss.netty.channel.*;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-import java.net.ConnectException;
-import java.util.concurrent.atomic.AtomicBoolean;
-
public class StormClientHandler extends SimpleChannelUpstreamHandler {
private static final Logger LOG =
LoggerFactory.getLogger(StormClientHandler.class);
private Client client;
- long start_time;
StormClientHandler(Client client) {
--- End diff --
If all this code does now is log error messages can we drop the Client from
the constructor and rename it to something that describes what it does better?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
