[
https://issues.apache.org/jira/browse/STORM-244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14017658#comment-14017658
]
ASF GitHub Bot commented on STORM-244:
--------------------------------------
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/incubator-storm/pull/132#discussion_r13383216
--- Diff: storm-core/test/clj/backtype/storm/drpc_test.clj ---
@@ -218,3 +220,13 @@
(.shutdown cluster)
(.shutdown drpc)
))
+
+(deftest test-drpc-timeout-cleanup
+ (let [queue (ConcurrentLinkedQueue.)
+ delay-seconds 2]
--- End diff --
Why 2 instead of 1? Also could we stub TIMEOUT-CHECK-SECS to something
smaller like 1 so that the test can run faster?
> DRPC timeout can return null instead of throwing an exception
> -------------------------------------------------------------
>
> Key: STORM-244
> URL: https://issues.apache.org/jira/browse/STORM-244
> Project: Apache Storm (Incubating)
> Issue Type: Bug
> Reporter: Robert Joseph Evans
>
> In DPRC there is a race condition when the cleanup method is called between
> releasing the sem, cleaning up the atoms and the blocked thread fetching the
> result. It looks like it is possible on a timeout that the sem will be
> released but by the time the thread blocked on the sem actually wakes up the
> result may have been removed, causing a null to be returned instead of an
> exception being thrown.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
