[
https://issues.apache.org/jira/browse/STORM-244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14018769#comment-14018769
]
ASF GitHub Bot commented on STORM-244:
--------------------------------------
Github user revans2 commented on the pull request:
https://github.com/apache/incubator-storm/pull/132#issuecomment-45217514
So with this new code if someone somehow sets a config that has a key of 5
it will essentially adjust the TIMEOUT-CHECK-SECS value? That seems ugly to
me. I was thinking of using conjure but because TIMEOUT-CHECK-SECS is not a
function I see that we cannot stub it. Perhaps we should just make a true key
for it in Config.
> DRPC timeout can return null instead of throwing an exception
> -------------------------------------------------------------
>
> Key: STORM-244
> URL: https://issues.apache.org/jira/browse/STORM-244
> Project: Apache Storm (Incubating)
> Issue Type: Bug
> Reporter: Robert Joseph Evans
>
> In DPRC there is a race condition when the cleanup method is called between
> releasing the sem, cleaning up the atoms and the blocked thread fetching the
> result. It looks like it is possible on a timeout that the sem will be
> released but by the time the thread blocked on the sem actually wakes up the
> result may have been removed, causing a null to be returned instead of an
> exception being thrown.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
