[
https://issues.apache.org/jira/browse/STORM-400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14060301#comment-14060301
]
ASF GitHub Bot commented on STORM-400:
--------------------------------------
Github user kishorvpatil commented on the pull request:
https://github.com/apache/incubator-storm/pull/184#issuecomment-48863840
@HeartSaVioR, Recently, I had to create work around #180 for [THRIFT-1665](
https://issues.apache.org/jira/browse/THRIFT-1665) which was fixed in 0.9.1
missing in 0.7.0. Also while I was working on another #150 and #151, I was not
able to use default thrift 0.7.0 compiler instead have to compile from [storm
specific branch](https://github.com/nathanmarz/thrift/tree/storm) in Nathan's
repo. This branch has many patches already available in latest thrift - except
the hash code function. So I thought it might be good to avoid using older
version to gain from many fixed latest thrift already provides and use default
compiler if possible.
@Jens-G As you suggested, trivial hash function(always returning 0) could
be used if that's generic implementation thrift should provide. I suppose, for
storm in particular, since these objects would added to clojure and jvm
collections, performance would be an issue. Since Nathan originally implemented
the thrift patch https://github.com/apache/thrift/pull/156, he might be able to
better justify the change.
> Thrift upgrade to 0.9.1
> -----------------------
>
> Key: STORM-400
> URL: https://issues.apache.org/jira/browse/STORM-400
> Project: Apache Storm (Incubating)
> Issue Type: Dependency upgrade
> Reporter: Kishor Patil
> Labels: master, thrift
>
> Upgrade Thrift to 0.9.1
--
This message was sent by Atlassian JIRA
(v6.2#6252)
