[
https://issues.apache.org/jira/browse/STORM-400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14060391#comment-14060391
]
ASF GitHub Bot commented on STORM-400:
--------------------------------------
Github user Jens-G commented on the pull request:
https://github.com/apache/incubator-storm/pull/184#issuecomment-48871059
@kishorvpatil:
First of all, I really appreciate your work on this topic, and I will
commit the Thrift patch as soon as it passes the review.
> As you suggested, trivial hash function(always returning 0)
> could be used if that's generic implementation thrift should provide
No. You are misrepresenting my statement. I did not say "always return 0",
instead I said "try to improve your has function, because it is badly
implemented". [The typical way a hash function is built is by XOR-ing the
values like
this](http://stackoverflow.com/questions/4005318/how-to-implement-a-good-hash-function-in-python):
function hash() {
int value = 0;
value = value * 101 ^ foo.hash();
value = value * 101 ^ bar.hash();
value = value * 101 ^ baz.hash();
return value
}
If you would have read the links (especialy the SO one), you would have
found out. And please don't tell me that someone else made the mistake. **You**
are the one proposing the patch, so please take over some responsibility. You
are of course free to inform the original author about the improvements that
could be made to make his code better.
> Thrift upgrade to 0.9.1
> -----------------------
>
> Key: STORM-400
> URL: https://issues.apache.org/jira/browse/STORM-400
> Project: Apache Storm (Incubating)
> Issue Type: Dependency upgrade
> Reporter: Kishor Patil
> Labels: master, thrift
>
> Upgrade Thrift to 0.9.1
--
This message was sent by Atlassian JIRA
(v6.2#6252)
